Misc ACC Results Companion 1.24.0

[Doug Duthie]

Hi Doug,

I've attached both files. Same session, 1 from my PC and the other from the server.

I think it might be related to when players leave the session before the end and get evicted from the driver list. I did a couple of tests this evening, but as luck would have it, I can't recreate the condition. I'll run some more tests at the weekend to ensure I have this fixed

 

[patch.0]

Hi Doug, the fuel calculation for the GT4 seems not be working. All the cars show 0 Fuel per lap.
Regars.

 

[Doug Duthie]

Hi Doug, the fuel calculation for the GT4 seems not be working. All the cars show 0 Fuel per lap.
Regars.

It only works it out for the GT4s after you've run at least one session with that car on that track. I didn't have time to populate estimates unfortunately.

Are you saying it isn't showing fuel usage even after you've run at least one session? If not, try pressing the Re-calculate button and it will re-calculate all fuel statistics based on past history

 

[Doug Duthie]

Doug Duthie updated ACC Results Companion with a new update entry:

ACC Results Companion V1.6.7

• Existing process check (prevent starting 2 versions of app)
• Revised car icons
• Handle lost ACC broadcast session
• Better handling if ACC is restarted while the app is running
• Handle drivers leaving early (ensure the are included in results and don't cause session loss)

Read the rest of this update entry...

 

[Doug Duthie]

ACC Results Companion V1.6.7 Released

This mainly covers a few bug fixes/niggles

Existing process check
There were possible issues if ACC Results Companion didn't close properly (one of the threads was left running). This could lead to ACC Broadcast connections not being made the next time it started. The closedown procedure and checks has been improved, but as a safety measure, the app now checks for any other instances of ACCResults running and won't start if it finds any. If this occurs, locate the task in Task Manager and kiil it, before starting the app again.

Revised car brand icons
Some of the icons didn't display too well in the list boxes, so these have been improved in some cases.

Handle lost ACC Broadcast session
Very occasionally, the new broadcast session will close immediately after being opened. The app should now handle this situation better.

I still need to look at the root cause, although I have some thoughts. To properly close the connection, a message needs to be send indicating the connection id to terminate (to prevent resource leaks), before the connection is closed. It looks as though when a new connection is requested, this occasionally gets the old connection id before shutting down. I think perhaps it is processing the termination message for the old connection. I'll look at ways of better handling the connection recycling.

ACC Restarted
If sessions were run, and then ACC restarted, it is possible that new sessions won't be detected. The conditions to detect new sessions have now been changed to cover this.

Drivers leaving session
There was a situation where I think if other drivers left a MP session early, they would be evicted from the driver list. This could either cause their laps not to be saved or could cause the entire session to be lost. This scenario is now catered for.

It should be noted that while testing I have not been able to recreate this scenario any more, so this may now not occur with ACC 1.5.1

 

[unpierrot]

Version 1.6.7 doesn't want to close and hang. Windows detect unresponsive software and close it with a warning window.
Only open ACCR and select one entry in session is enough to make it hang.
Open ACCR and close it without selecting anything makes it close correctly.

correct close log:

[00000008] 2020-07-25 13:00:20 INFO FileUtils.OpenBroadcastConnectionDetails : Broadcast/UDP configured on port [9000]
[00000001] 2020-07-25 13:00:27 INFO ACCResults.formCloseRequested : *** Form close requested ***
[00000005] 2020-07-25 13:00:27 INFO ARCProcessStats.MonitorMemory : *** Memory monitor closing ***
[00000008] 2020-07-25 13:00:27 DEBUG ARCSharedMemoryMonitor..ctor : Stop event received
[00000006] 2020-07-25 13:00:27 INFO DBWriterTask.ProcessDbRequest : Stop event received
[00000008] 2020-07-25 13:00:27 INFO ARCSharedMemoryMonitor..ctor : *** Shared Memory monitor closing ***
[00000006] 2020-07-25 13:00:27 INFO DBWriterTask.ProcessDbRequests : *** DB Writer task closing ***
[00000001] 2020-07-25 13:00:27 INFO ACCResults.formCloseRequested : Process statistics process has closed
[00000001] 2020-07-25 13:00:27 INFO ACCResults.formCloseRequested : Shared memory/Broadcast process has closed
[00000001] 2020-07-25 13:00:27 INFO ACCResults.formCloseRequested : DB Writer process has closed
[00000001] 2020-07-25 13:00:27 INFO ResultsDB.Close : Closing DB connection

incorrect one:

[00000008] 2020-07-25 13:00:32 INFO FileUtils.OpenBroadcastConnectionDetails : Broadcast/UDP configured on port [9000]
[00000001] 2020-07-25 13:00:45 INFO ACCResults.formCloseRequested : *** Form close requested ***


edit :
current installed .NetFramework (latest)

https://support.microsoft.com/en-us/help/4562900/kb4562900-cumulative-update-for-net-framework

New sessions are correctly populated, no issue other than close hang.
Menu Quit from taskbar or clicking X makes ACCR hang.

 

[Doug Duthie]

Version 1.6.7 doesn't want to close and hang. Windows detect unresponsive software and close it with a warning window.
Only open ACCR and select one entry in session is enough to make it hang.
Open ACCR and close it without selecting anything makes it close correctly.

correct close log:

[00000008] 2020-07-25 13:00:20 INFO FileUtils.OpenBroadcastConnectionDetails : Broadcast/UDP configured on port [9000]
[00000001] 2020-07-25 13:00:27 INFO ACCResults.formCloseRequested : *** Form close requested ***
[00000005] 2020-07-25 13:00:27 INFO ARCProcessStats.MonitorMemory : *** Memory monitor closing ***
[00000008] 2020-07-25 13:00:27 DEBUG ARCSharedMemoryMonitor..ctor : Stop event received
[00000006] 2020-07-25 13:00:27 INFO DBWriterTask.ProcessDbRequest : Stop event received
[00000008] 2020-07-25 13:00:27 INFO ARCSharedMemoryMonitor..ctor : *** Shared Memory monitor closing ***
[00000006] 2020-07-25 13:00:27 INFO DBWriterTask.ProcessDbRequests : *** DB Writer task closing ***
[00000001] 2020-07-25 13:00:27 INFO ACCResults.formCloseRequested : Process statistics process has closed
[00000001] 2020-07-25 13:00:27 INFO ACCResults.formCloseRequested : Shared memory/Broadcast process has closed
[00000001] 2020-07-25 13:00:27 INFO ACCResults.formCloseRequested : DB Writer process has closed
[00000001] 2020-07-25 13:00:27 INFO ResultsDB.Close : Closing DB connection

incorrect one:

[00000008] 2020-07-25 13:00:32 INFO FileUtils.OpenBroadcastConnectionDetails : Broadcast/UDP configured on port [9000]
[00000001] 2020-07-25 13:00:45 INFO ACCResults.formCloseRequested : *** Form close requested ***


edit :
current installed .NetFramework (latest)

https://support.microsoft.com/en-us/help/4562900/kb4562900-cumulative-update-for-net-framework

OK - I'll take a look at it

 

[unpierrot]

To help you figure it out
Open ACCR, click on one session, move cursor to other session with down arrow - close ok
Open ACCR, click on one session, select another tab, go back to session tab - close ok

Open ACCR, click on one session - close Nok

 

[Doug Duthie]

To help you figure it out
Open ACCR, click on one session, move cursor to other session with down arrow - close ok
Open ACCR, click on one session, select another tab, go back to session tab - close ok

Open ACCR, click on one session - close Nok

OK...I've managed to reproduce this once. If I can reliably reproduce, I should be able to get to the bottom of it

 

[unpierrot]

Update about close issue.
Made some cleanup on my game computer and after uninstalling Microsoft Visual Studio, issue disappears.
So it's related to .Net dll version.

edit : to avoid that kind of issue, you can see which dlls are used by your software with a dependency walker and embed them to your install. Dlls inside working folder take precedence over system one.
Just take care to not embed debug dlls.

Or you can try to understand what's the difference between 1.6.7 and 1.6.6 because older version was working fine even with VS installed on my system.

 

[unpierrot]

Finally close can still hang after uninstalling VS. Clearly very less frequently but still present.
Same last entry in log than in my other post

[00000001] 2020-07-26 13:31:38 INFO ACCResults.formCloseRequested : *** Form close requested ***

 

[Doug Duthie]

Doug Duthie updated ACC Results Companion with a new update entry:

ACC Results Companion V1.6.8

• Wait for old UDP connect to be dispose by ACC before requesting new one
• Speed up intialisation (preparation of car/circuit definitions)
• Race records displayed for specific car class
• Filter laps/leaderboard by cup category and driver category (as well as car class)
• Form close - don't freeze UI while closing
• Drivers now colour coded according to category
• Race numbers now colour coded according to cup

Read the rest of this update entry...

 

[Doug Duthie]

ACC Results Companion V1.6.8 Released

Apologies for the quick-fire releases. While the last release was predominantly bug-fixes and stability enhancements, this release continues what I had intended for the GT4 DLC. Headlines are:-

Multi-class Results
Multi-class results are now implemented so you can see how you are doing in your car class, team cup category and your driver category.

Each driver is now colour coded according to their rating (Bronze, Silver, Gold and Platinum). The race number is colour coded according to the team cup category (Pro, ProAm, Am, Silver and National) using the ACC colours. Also, the race number is flagged with the class tag (blue=GT4, yellow=ST, green=Cup, none=GT3) as appears on the ACC results.

In addition, laps/results can be filtered on car class...

cup category...

and driver category

Positions will be calculated for each class. Similar filters exist on the leaderboard.

Some broadcast connections being rejected
When a connection is terminated, a close message is sent to ACC, giving the connection ID to free resources. Very occasionally, it appears that ACC gives the same connection ID on a new connection before the free resources message is processed. The free resource message is then processed on the new connection which then won't send any messages.

Now, ACC Results Companion will wait until acknowledgement has been received that the old connection is shutdown before opening a new connection.

In addition to this, if a connection is lost part way through a session, it should be re-initiated correctly

Freeze on shutdown
Occasionally, the app would freeze on shutdown. It should now wait for threads to close without locking the UI. If threads don't close in 5 seconds, the app will close anyway

 

[Doug Duthie]

Finally close can still hang after uninstalling VS. Clearly very less frequently but still present.
Same last entry in log than in my other post

[00000001] 2020-07-26 13:31:38 INFO ACCResults.formCloseRequested : *** Form close requested ***

I'm not sure if it going to fix it, but can you try V1.6.8. It should no longer freeze the UI on shutdown

 

[laurent7979]

Hi, great app
However I don't understand the Race Qualy Record/Slowest times in Session panel : where are these times extracted from ? They don't seem to match AI or MP times.

 

[Doug Duthie]

Hi, great app
However I don't understand the Race Qualy Record/Slowest times in Session panel : where are these times extracted from ? They don't seem to match AI or MP times.

They are taken from the real world SRO/Blancpain events from either 2018 or 2019. It is intended to see how you compare againstreal drivers

 

[Doug Duthie]

Doug Duthie updated ACC Results Companion with a new update entry:

ACC Results Companion V1.6.9

• Car/Track History Enhancements
  • Exclude invalid laps
  • Exclude in/out laps
  • Need lap type in column list
  • Optional heatmap
  • Deltas incorrect - always relative to 0
  • Lap record not updated for class
• Manual option to invalidate/clear invalid laps
• Correct some real world records (Cup class)

Read the rest of this update entry...

 

[Doug Duthie]

ACC Results Companion V1.6.9 Released

Headlines:-

Car/Track History Enhancements
As well as a couple of fixes (Real world delta comparison broken & records not updated for class), the following enhancement has gone in. You can now, exclude invalid laps and In/Out laps.

Also, you can view lap times as a heapmap

Manually Invalidate/Clear Invalid Lap
This is intended mainly for server results file imports where not all invalid laps are reported as such. If you verify (eg via replay) that a lap is invalid but isn't flagged, you can manually invalidate it so it doesn't appear in the leaderboards.

There is also a Clear invalid lap just in case you want to revert a change.

Note, as the DB writes are now asynchronous now, the update may not be visible immediately. Click on the session again to refresh the laps after a seconds or so.

Real life race records
As mentioned above, some of the Cup records have been corrected.

The control should update if the class filter is changed (to display records for class) or for the class of the highlighted car. It is proving problematic to obtain results for all classes. Not all classes run at all of the ACC tracks, and even where they do, the results provided are very inconsistent (some don't publish qualifying or race or both). Also, it is not always clear if they run on the same version of the circuit. If the class results are not available, the the overall record (effectively GT3) results are displayed

In terms of coverage:-

• GT3 - all track records available
• GT4 - All bar Kyalami and Laguna Seca available
  • Note: Paul Ricard is included but i think they use the Chicane Montreal so it isn't a direct comparison
• Cup - Laguna Seca, Misano, Paul ricard, Suzuka and Zolder not available
• Super Trofeo - I couldn't find any results for these

 

[sonicviz]

Looking good now, thanks.

 

[sonicviz]

Suggestion: It would be really useful if you could also use this for AMS2.
Details here: https://forum.reizastudios.com/threads/race-records-and-tracking.12362/#post-90206